Optimize registerMounts by removing unused function #27373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrow4a, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 and @DeepDiver1975 to be potential reviewers. |
|
Without that line, this is what happens when you create new user: |
mrow4a
changed the title
|
ok, rebased and now it is ok |
mrow4a
force-pushed
the
rem_abmg_queries
branch
from
a65d123
to
17ca722
Compare
|
@DeepDiver1975 @PVince81 To review. This block was unused, however found out that will not optimize much. I need further digging. |
|
Great, this means that the unit tests in question were rewritten in a better way |
|
👍 |
1 task
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// filter out non-proper storages coming from unit testsThis comment raised my attention, since production code should not optimize unit tests.