Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): add uploader #39945

Merged
merged 1 commit into from
Sep 1, 2023
Merged

feat(files): add uploader #39945

merged 1 commit into from
Sep 1, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 17, 2023 •
edited
Loading

Ref #39914
Closes #30069
Closes #38041

Screenshots

image
image
image
image

Followups:

  • Ignore this blank space, this is from the components
    image
  • Add more new XXXXXXX items
  • Implement template picker

@skjnldsv skjnldsv self-assigned this Aug 17, 2023
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Aug 17, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 17, 2023
Closed
26 tasks
This was referenced Aug 18, 2023
Merged
Merged
@skjnldsv skjnldsv requested review from a team, artonge, Pytal, szaimen and nimishavijay and removed request for a team September 1, 2023 08:44
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 1, 2023
@skjnldsv skjnldsv marked this pull request as ready for review September 1, 2023 08:45
@skjnldsv skjnldsv force-pushed the feat/f2v/uploader branch 3 times, most recently from 991d0ed to e87bd16 Compare September 1, 2023 08:54
@szaimen

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
This was referenced Sep 1, 2023
Closed
Closed
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2023

One small remark: the new button looks like this since #39884. can we do the same here?

nextcloud-libraries/nextcloud-upload#922

Also the progress bar does not seem to work well on mobile currently

Not scheduled for now
nextcloud-libraries/nextcloud-upload#816

juliusknorr
juliusknorr approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like charm 👍

szaimen
szaimen approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a fast test and seems to work good :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2023
@skjnldsv
feat(files): add uploader
52590a7 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit e3c127f into master Sep 1, 2023
@skjnldsv skjnldsv deleted the feat/f2v/uploader branch September 1, 2023 12:54
@szaimen
Copy link
Contributor

szaimen commented Sep 1, 2023

🎉🎉🎉

@joshtrichards joshtrichards mentioned this pull request Sep 2, 2023
Closed
@jancborchardt jancborchardt mentioned this pull request Oct 3, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Set new folder name inline like renaming [F2V] Upload manager
3 participants
@skjnldsv @szaimen @juliusknorr