feat: 28 Files2vue compatibility #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
changed the title
juliusknorr
reviewed
Aug 11, 2023
Comment on lines
+52
to
+57
| webpackConfig.plugins.push(new webpack.ProvidePlugin({ | ||
| Buffer: ['buffer', 'Buffer'], | ||
| })) | ||
| webpackConfig.resolve.fallback = { | ||
| buffer: require.resolve('buffer'), | ||
| } |
There was a problem hiding this comment.
No clue, but it's required somehow
ref nextcloud-libraries/webpack-vue-config#450 (comment)
Passing run #11869 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Will take over for finishing tests and adjusting cypress to work with the f2v merge |
juliusknorr
force-pushed
the
feat/28-files
branch
from
c5495b0 to
e9b3ff9
Compare
juliusknorr
changed the title
juliusknorr
force-pushed
the
feat/28-files
branch
from
5090f44 to
5ca136b
Compare
1 task
skjnldsv
commented
Aug 18, 2023
max-nextcloud
force-pushed
the
feat/28-files
branch
from
52013d6 to
335d67b
Compare
juliusknorr
reviewed
Aug 21, 2023
juliusknorr
force-pushed
the
feat/28-files
branch
from
cf0c465 to
1725bde
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
File names are now rendered in two spans which breaks the assertion that the row contains `test.md`. But that is nothing text should worry about anyway. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
feat/28-files
branch
from
1725bde to
96523eb
Compare
|
/compile |
|
cypress tests that failed on the last run succeeded for me locally. 🤷 Failure was introduced later in server master branch. |
max-nextcloud
force-pushed
the
feat/28-files
branch
2 times, most recently
from
38094e1 to
140143e
Compare
max-nextcloud
force-pushed
the
feat/28-files
branch
from
140143e to
cf725fa
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
feat/28-files
branch
4 times, most recently
from
904ffa8 to
542ddbb
Compare
See also nextcloud/server#40065 Signed-off-by: Max <max@nextcloud.com>
basename and extension are now split. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
feat/28-files
branch
from
542ddbb to
0a3705e
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Follow up ticket:
|
max-nextcloud
approved these changes
Aug 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextcloud/server#39808
Fixes #4626
@nextcloud/dialogsand use it by default server#39792 is merged/F2V final overview https://github.com/nextcloud/server/issues/39914