Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid throwing on folder previews as there are none #39950

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 18, 2023

Otherwise there is an uncaught exception thrown which blocks cypress tests in text.

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Aug 18, 2023
@juliusknorr juliusknorr force-pushed the bugfix/uncaught-preview-promise branch from 033cd6f to 08360b9 Compare August 18, 2023 07:39
@juliusknorr juliusknorr force-pushed the bugfix/uncaught-preview-promise branch from 08360b9 to 9c4e8a2 Compare August 21, 2023 15:26
@juliusknorr juliusknorr marked this pull request as ready for review August 21, 2023 15:27
@skjnldsv skjnldsv force-pushed the bugfix/uncaught-preview-promise branch from 9c4e8a2 to f4adb0d Compare August 22, 2023 08:37
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 22, 2023
@skjnldsv
Copy link
Member

/compile amend /

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the bugfix/uncaught-preview-promise branch from f4adb0d to 79c240a Compare August 22, 2023 08:49
@juliusknorr juliusknorr merged commit 2bb48a6 into master Aug 22, 2023
@juliusknorr juliusknorr deleted the bugfix/uncaught-preview-promise branch August 22, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants