Merge gmp and bcmath module checks with the existing PHP modules setupcheck #42829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
come-nc
requested review from
a team,
ArtificialOwl,
blizzz and
Altahrim
and removed request for
a team
blizzz
reviewed
Jan 16, 2024
|
Still in draft state, but review label is set? |
It’s in draft because target is not main yet, I have PR waiting in line for setup checks. Still safe to review. |
come-nc
force-pushed
the
enh/migrate-settimelimit-setupcheck
branch
from
6ee1138 to
a77bab2
Compare
come-nc
force-pushed
the
enh/migrate-webauthn-modules-setupcheck
branch
from
11d62a8 to
fdb21b9
Compare
Base automatically changed from
enh/migrate-settimelimit-setupcheck
to
master
January 18, 2024 14:33
come-nc
force-pushed
the
enh/migrate-webauthn-modules-setupcheck
branch
from
fdb21b9 to
fbb3495
Compare
Altahrim
reviewed
Jan 22, 2024
…p check Also add description for why each module is recommended Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/migrate-webauthn-modules-setupcheck
branch
from
fbb3495 to
f13b2fb
Compare
Altahrim
approved these changes
Jan 22, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
Failures not related |
nickvergessen
approved these changes
Jan 23, 2024
nfebe
approved these changes
Jan 23, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Merge gmp and bcmath module checks with the existing PHP modules setupcheck
Also add description for why each module is recommended
Checklist