Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Migrate setup checks to new API - round 3 #44268

Merged
merged 13 commits into from
Apr 16, 2024
Merged

[stable28] Migrate setup checks to new API - round 3 #44268

merged 13 commits into from
Apr 16, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 18, 2024 •
edited
Loading

come-nc added 13 commits March 18, 2024 11:08
@come-nc
Migrate memcached PHP module setup check to new API
06952c4 
Merged it with the other existing memcache setup check as it fits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate set_time_limit setup check to new API
b31d516 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Merge gmp and bcmath module checks with the existing PHP modules setu…
b2cc51c 
…p check

Also add description for why each module is recommended

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix description for exif PHP module
ec0a9ac 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add missing recommended modules gmp and bcmath
873912c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove bz2 leftover description
bfb451c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate MySQL utf8mb4 check to new SetupCheck API
28dafd9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate available temp space check to new SetupCheck API
9dcf13f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove old version of temporary space setup check and fix tests
11cde30 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Merge writable temporary space check with the s3 one, and improve
b92024e 
It will now show available space and path of both PHP and Nextcloud
 temporary directories if they differ.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate fair use of free push service check to new SetupCheck API
44c0b7d 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Rename to "Push service" and enable on all instances to avoid trouble
1ad788d 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate debug mode check to new SetupCheck API
71e0510 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Mar 18, 2024
@come-nc come-nc added this to the Nextcloud 28.0.5 milestone Mar 18, 2024
@come-nc come-nc self-assigned this Mar 18, 2024
@come-nc come-nc mentioned this pull request Mar 18, 2024
Closed
33 tasks
@come-nc come-nc requested review from susnux, a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team March 18, 2024 10:17
@susnux susnux merged commit 2392602 into stable28 Apr 16, 2024
53 checks passed
@susnux susnux deleted the backport/setupchecks-3/stable28 branch April 16, 2024 13:19
@Altahrim Altahrim mentioned this pull request Apr 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@susnux susnux susnux approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @susnux @Altahrim