Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): disable Unshare until proper fix #43152

Merged
merged 2 commits into from
Jan 27, 2024
Merged

fix(files): disable Unshare until proper fix #43152

merged 2 commits into from
Jan 27, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 26, 2024

Until we fix it for 28.0.3, it's safer to use the Delete wording

fix #43130

@skjnldsv skjnldsv added this to the Nextcloud 28.0.2 milestone Jan 26, 2024
@skjnldsv skjnldsv self-assigned this Jan 26, 2024
@skjnldsv skjnldsv requested review from a team, nfebe, szaimen, sorbaugh and susnux and removed request for a team January 26, 2024 17:12
@nickvergessen

This comment was marked as resolved.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

/backport! d06ed4d to stable28

@skjnldsv skjnldsv requested a review from szaimen January 27, 2024 12:10
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then but didnt test

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2024
@skjnldsv skjnldsv merged commit b6f64cb into master Jan 27, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Contents inside shared directory can be "Unshared" but are effectively deleted
4 participants