fix(files): add mount root property and adjust delete wording #43217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
nfebe and
sorbaugh
and removed request for
a team
skjnldsv
commented
Jan 30, 2024
Comment on lines
+34
to
+36
| registerDavProperty('nc:share-attributes', { nc: 'http://nextcloud.org/ns' }) | ||
| registerDavProperty('oc:share-types', { oc: 'http://owncloud.org/ns' }) | ||
| registerDavProperty('ocs:share-permissions', { ocs: 'http://open-collaboration-services.org/ns' }) |
There was a problem hiding this comment.
We should remove them from the default fetch, files_sharing might be disabled
skjnldsv
force-pushed
the
fix/sharing-delee-leave-share
branch
2 times, most recently
from
3aa1b86 to
c91ca33
Compare
artonge
reviewed
Jan 30, 2024
skjnldsv
force-pushed
the
fix/sharing-delee-leave-share
branch
2 times, most recently
from
01c9425 to
88ec1dc
Compare
artonge
approved these changes
Jan 31, 2024
8 tasks
skjnldsv
force-pushed
the
fix/sharing-delee-leave-share
branch
from
88ec1dc to
6309b59
Compare
come-nc
reviewed
Feb 6, 2024
come-nc
approved these changes
Feb 6, 2024
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/sharing-delee-leave-share
branch
from
6309b59 to
ca61b11
Compare
skjnldsv
added
4. to release
|
/backport 6cf4fe1 to stable28 |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #43152
Fix #40940