Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): ask for confirm if deleting 5 items or more #43231

Merged
merged 2 commits into from
Feb 7, 2024
Merged

feat(files): ask for confirm if deleting 5 items or more #43231

merged 2 commits into from
Feb 7, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 31, 2024 •
edited
Loading

Fix #32011
Needs #43217

image
@nextcloud/designers

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Jan 31, 2024
@skjnldsv skjnldsv requested review from artonge and a team January 31, 2024 09:12
@skjnldsv skjnldsv self-assigned this Jan 31, 2024
@skjnldsv skjnldsv requested review from nfebe and sorbaugh and removed request for a team January 31, 2024 09:12
@skjnldsv skjnldsv changed the title fix(files): add mount root property and adjust delete wording @skjnldsv feat(files): ask for confirm if deleting 5 items or more Jan 31, 2024
@skjnldsv skjnldsv changed the title @skjnldsv feat(files): ask for confirm if deleting 5 items or more feat(files): ask for confirm if deleting 5 items or more Jan 31, 2024
artonge
artonge approved these changes Jan 31, 2024
View reviewed changes
apps/files/src/actions/deleteAction.ts Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/warn-batch-delete branch 2 times, most recently from ac49716 to 672faf3 Compare January 31, 2024 10:54
@skjnldsv skjnldsv force-pushed the fix/sharing-delee-leave-share branch 2 times, most recently from 01c9425 to 88ec1dc Compare January 31, 2024 10:59
@skjnldsv skjnldsv requested a review from susnux February 5, 2024 15:59
@skjnldsv skjnldsv force-pushed the fix/sharing-delee-leave-share branch from 88ec1dc to 6309b59 Compare February 5, 2024 16:07
szaimen
szaimen approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective :)

@skjnldsv skjnldsv force-pushed the fix/sharing-delee-leave-share branch from 6309b59 to ca61b11 Compare February 6, 2024 16:44
Base automatically changed from fix/sharing-delee-leave-share to master February 6, 2024 19:25
@skjnldsv skjnldsv force-pushed the feat/warn-batch-delete branch from 3dd519f to bdd0c19 Compare February 7, 2024 09:29
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2024
@skjnldsv
feat(files): ask for confirm if deleting 5 items or more
12fe865 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
chore: recompile assets
1db40e9 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/warn-batch-delete branch from bdd0c19 to 1db40e9 Compare February 7, 2024 10:13
@skjnldsv skjnldsv merged commit 4ce10d0 into master Feb 7, 2024
84 of 85 checks passed
@skjnldsv skjnldsv deleted the feat/warn-batch-delete branch February 7, 2024 11:00
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Mar 7, 2024
Closed
@BloodyIron BloodyIron mentioned this pull request Jul 18, 2024
Closed
@jancborchardt jancborchardt mentioned this pull request Sep 11, 2024
Open
@joshtrichards joshtrichards mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@susnux susnux susnux approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files feature: trashbin
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

File Delete Confirmation Dialog
4 participants
@skjnldsv @susnux @artonge @szaimen