Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show the id of last author in versions metadata #44049

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Mar 6, 2024

Summary

  • The oc_files_version table is what stores the version information of each file. Each version can be categorized by its file_id and timestamp columns, but there is also a metadata column which stores JSON directly.
  • Everytime the file node is overwritten, we should have an event listener that gets triggered and updates that meta data column with:
{
  "author": "versionAuthorID",
}
  • This PR also allows us to also potentially store messages that go along with a file version change, similar to a git commit in future releases! I tried to make this as flexible as possible, and also to make a PR as small as possible, but I believe these commits have to be bundled together to allow for a better sense while reading this commit 😋

Screenshots

Untitled.video.-.Made.with.Clipchamp.6.mp4

image

Checklist

@emoral435 emoral435 changed the title feat: in progress... feat: show the name of last editor in versions Mar 7, 2024
@emoral435 emoral435 self-assigned this Mar 7, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Mar 7, 2024
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 3a2eb8c to 694090a Compare March 7, 2024 16:11
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like that you are using proper doc comments :)

@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from e429295 to 130df29 Compare March 8, 2024 15:18
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 39cb2b1 to f1a6ffe Compare March 8, 2024 15:47
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 59ba0b3 to 2f42bbf Compare March 9, 2024 17:05
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 2f42bbf to 33903d8 Compare March 9, 2024 17:22
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 77ed897 to ae7dfbd Compare March 9, 2024 18:39
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch from ae7dfbd to 9651041 Compare March 10, 2024 17:18
@emoral435 emoral435 marked this pull request as ready for review March 10, 2024 17:19
@emoral435 emoral435 requested a review from susnux March 10, 2024 17:19
@susnux
Copy link
Contributor

susnux commented Mar 11, 2024

Really nice work 🚀 Just a few nitpicks and comments :)

@artonge artonge added the pending documentation This pull request needs an associated documentation update label Mar 11, 2024
@emoral435
Copy link
Contributor Author

I fixed the inconsistent typing of variables within functions, bad use of double-quotes, and licensing :) Just need to do documentation, but as I am at university currently, I will save that for when I get back home! 🚀 will edit this comment to include the updated documentations PR

@emoral435 emoral435 requested a review from susnux March 11, 2024 15:35
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@emoral435 emoral435 changed the title feat: show the name of last editor in versions feat: show the id of last author in versions Mar 11, 2024
@emoral435 emoral435 changed the title feat: show the id of last author in versions feat: show the id of last author in versions metadata Mar 11, 2024
@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 11, 2024
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 015f5ab to 148aa46 Compare March 11, 2024 18:10
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 148aa46 to bfacc6d Compare March 11, 2024 20:58
@emoral435 emoral435 enabled auto-merge March 11, 2024 20:58
@emoral435 emoral435 merged commit f99b820 into master Mar 11, 2024
160 checks passed
@emoral435 emoral435 deleted the feat/show-name-of-user-in-versions branch March 11, 2024 21:17
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 13, 2024
As of: nextcloud/server#44049
Server equivalent: nextcloud/server#44175

Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 13, 2024
As of: nextcloud/server#44049
Server equivalent: nextcloud/server#44175

Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024
As of: nextcloud/server#44049
Server equivalent: nextcloud/server#44175

Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024
As of: nextcloud/server#44049
Server equivalent: nextcloud/server#44175

Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024
As of: nextcloud/server#44049
Server equivalent: nextcloud/server#44175

Signed-off-by: Louis Chemineau <louis@chmn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: versions pending documentation This pull request needs an associated documentation update 🍀 2024-Spring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants