-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: author displayname and avatar on versions #44109
Conversation
7049690
to
5f16f3c
Compare
148aa46
to
bfacc6d
Compare
5f16f3c
to
08c71bc
Compare
08c71bc
to
eba635d
Compare
This PR will only show the visual changes once NcVue gets a bump to use one of the chained PR's, but for now, no breaking changes are introduced with this PR, so this can get in before I go on vacation 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! What a cool feature! :)
- I would only suggest that the positions of the avatar and name be exchanged, and the avatar size be decreased so that it looks a bit more like a user bubble
- everything in the first time can be in
--color-main-text
and everything on the subline can be--color-text-maxcontrast
:)
eba635d
to
bcff895
Compare
@nimishavijay |
bcff895
to
3d01107
Compare
waiting for a bump to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
3d01107
to
ac62523
Compare
/compile |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
cefe7bf
to
56eebaf
Compare
Hi, |
This is a stacked PR
Summary
With the aforementioned PR's, this PR will allow file_version to display the author and avatar for each version
Checklist