Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date #44281

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date #44281

merged 1 commit into from
Mar 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 18, 2024 •
edited
Loading

Summary

If there is no expiryDate or date set, then ignore those. Also always include upcoming entries from the API because the result is cached.

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 18, 2024
@susnux susnux requested review from a team, ArtificialOwl, artonge and nfebe and removed request for a team March 18, 2024 16:53
@susnux susnux mentioned this pull request Mar 18, 2024
Merged
@susnux susnux force-pushed the fix/app-discover-fetcher branch 2 times, most recently from 0b3c2e8 to c9696d3 Compare March 18, 2024 17:05
@susnux susnux self-assigned this Mar 18, 2024
@susnux susnux force-pushed the fix/app-discover-fetcher branch from 6d4a3f5 to 220964b Compare March 18, 2024 18:13
@susnux @AndyScherzinger
fix(AppDiscoverFetcher): Do not remove entries as expired that have n…
bae133b 
…o expiry date

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger AndyScherzinger force-pushed the fix/app-discover-fetcher branch from 220964b to bae133b Compare March 19, 2024 08:36
@susnux susnux requested review from Pytal and come-nc March 19, 2024 11:17
@susnux susnux mentioned this pull request Mar 19, 2024
Merged
4 tasks
@AndyScherzinger AndyScherzinger merged commit 6e43466 into master Mar 19, 2024
167 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/app-discover-fetcher branch March 19, 2024 13:09
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@Pytal Pytal Awaiting requested review from Pytal

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@susnux susnux

Labels
bug feature: apps management 🍀 2024-Spring
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @Altahrim @artonge @AndyScherzinger