Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "Active users" and "Shares" charts and replace custom tooltips on Disk chart. #420

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Replace "Active users" and "Shares" charts and replace custom tooltips on Disk chart. #420

merged 1 commit into from
Jan 25, 2023

Conversation

JuliaKirschenheuter
Copy link
Collaborator

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 24, 2023 •
edited by ChristophWurst
Loading

  • Replace custom tooltips with additional information on Disk chart
  • Replace Active users chart with plain information
  • Replace Shares chart with plain (list) information
  • Replace custom tooltip on copy button with native one and add success / error notification.

Fixes #418

Before After
Screenshot from 2023-01-24 16-48-06 Screenshot from 2023-01-24 16-26-52
Screenshot from 2023-01-24 16-52-47 Screenshot from 2023-01-24 16-54-28
Screenshot from 2023-01-24 16-53-19 Screenshot from 2023-01-24 16-54-33
Screenshot from 2023-01-24 16-53-24 Screenshot from 2023-01-24 16-54-37

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 24, 2023
@nickvergessen
Copy link
Member

Finally no more weird graphs :D

When there are no shares we should however show "something"?
grafik

@JuliaKirschenheuter
Copy link
Collaborator Author

Finally no more weird graphs :D

When there are no shares we should however show "something"? grafik

@kesselb https://github.com/nextcloud/serverinfo/pull/420/files#diff-b86b31801e087ecdaaf18d4d9db5f4362120f71c7173386d118e94b2f1899ac9R275 am i right?

@nickvergessen
Copy link
Member

Should work, yeah
https://github.com/nextcloud/serverinfo/blob/master/lib/ShareStatistics.php#L50

@JuliaKirschenheuter
Copy link
Collaborator Author

/backport to stable25

@kesselb
Copy link
Collaborator

kesselb commented Jan 25, 2023

Welcome to the serverinfo team 🥳

@JuliaKirschenheuter
Replace custom tooltips with additional information on Disk chart. Re…
a821953 
…place Active users chart with plain information. Replace Shares chart with plain information.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/4-Replace_custom_tooltips_with_native_one_for_system_settings_page branch from 281c8a4 to a821953 Compare January 25, 2023 15:44
@nickvergessen nickvergessen mentioned this pull request Jan 25, 2023
Closed
@nickvergessen nickvergessen merged commit 152e8fc into master Jan 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/4-Replace_custom_tooltips_with_native_one_for_system_settings_page branch January 25, 2023 16:04
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 25, 2023
Merged
@kesselb kesselb mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@kesselb kesselb kesselb approved these changes

@artonge artonge Awaiting requested review from artonge

@PVince81 PVince81 Awaiting requested review from PVince81

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace custom tooltips with native one for system settings page
3 participants
@JuliaKirschenheuter @nickvergessen @kesselb