hide 'cancelled' statuses

[shinenelson]

Steps to reproduce

1. create a task
2. set status of task to 'cancelled'

Expected behaviour

The task should be removed from view. Ideally to a separate section, say, Cancelled Tasks like Completed Tasks

Actual behaviour

Nothing. The task just stays there as if nothing happened.

Server configuration

Operating system: Debian 10 "Buster"

Web server: Apache 2.4.38

Database: MariaDB 10.3.22

PHP version: 7.3.14

Nextcloud version: 18.0.4 ( git )

Tasks version: 0.13.1

Updated from an older Nextcloud or fresh install: Not Applicable but I've been upgrading via git since v11

Signing status: Integrity checker has been disabled. Integrity cannot be verified.

List of activated apps:

Enabled Apps

  - accessibility: 1.4.0
  - apporder: 0.9.0
  - audioplayer: 2.10.0
  - bookmarks: 3.0.13
  - calendar: 2.0.3
  - cloud_federation_api: 1.1.0
  - comments: 1.8.0
  - contacts: 3.3.0
  - dav: 1.14.0
  - deck: 1.0.1
  - documentserver_community: 0.1.5
  - federatedfilesharing: 1.8.0
  - federation: 1.8.0
  - files: 1.13.1
  - files_frommail: 0.4.0
  - files_markdown: 2.2.0
  - files_mindmap: 0.0.21
  - files_rightclick: 0.15.2
  - files_sharing: 1.10.1
  - files_trashbin: 1.8.0
  - files_versions: 1.11.0
  - lookup_server_connector: 1.6.0
  - mail: 1.3.5
  - maps: 0.1.6
  - metadata: 0.11.1
  - music: 0.14.1
  - news: 14.1.7
  - notes: 3.3.1
  - notifications: 2.6.0
  - oauth2: 1.6.0
  - ocsms: 2.1.7
  - onlyoffice: 4.1.4
  - ownpad: 0.6.14
  - passman: 2.3.5
  - passwords: 2020.5.0
  - phonetrack: 0.6.3
  - photos: 1.0.0
  - polls: 1.4.3
  - privacy: 1.2.0
  - provisioning_api: 1.8.0
  - recommendations: 0.6.0
  - settings: 1.0.0
  - sharebymail: 1.8.0
  - socialsharing_diaspora: 2.0.0
  - socialsharing_email: 2.0.0
  - socialsharing_twitter: 2.0.0
  - spreed: 8.0.9
  - support: 1.1.0
  - systemtags: 1.8.0
  - talk_simple_poll: 1.1.1
  - tasks: 0.13.1
  - text: 2.0.0
  - theming: 1.9.0
  - timetracker: 0.0.42
  - twofactor_backupcodes: 1.7.0
  - twofactor_gateway: 0.16.0
  - twofactor_nextcloud_notification: 2.3.0
  - twofactor_totp: 4.1.3
  - twofactor_u2f: 5.1.0
  - updatenotification: 1.8.0
  - viewer: 1.2.0
  - workflowengine: 2.0.0

Nextcloud configuration:

System Configuration

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.shinenelson.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "18.0.4.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "loglevel": 1,
        "maintenance": false,
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "app_install_overwrite": [
            "user_pwauth"
        ],
        "app.mail.imaplog.enabled": true,
        "app.mail.smtplog.enabled": true,
        "app.mail.smtp.timeout": 20,
        "app.mail.verify-tls-peer": false,
        "htaccess.RewriteBase": "\/",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpsecure": "tls",
        "mail_smtptimeout": "20",
        "mail_smtpauth": 1,
        "memcache.local": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        }
    }
}

Are you using external storage: no

Are you using encryption: yes

Are you using an external user-backend: no

Client configuration

Browser: Firefox 76.0.1

Operating system: Ubuntu 20.04

CalDAV-clients: Not applicable

[raimund-schluessler]

I guess it makes sense to not show canceled events in the list of tasks that are still to do. @nextcloud/designers Should we introduce another smart list showing only canceled tasks?

[raimund-schluessler]

Maybe we just show cancelled tasks in the completed view. Even if they aren't really completed, they are similar since for both completed and cancelled tasks there is nothing left to do.

[jancborchardt]

@raimund-schluessler sounds good to show them in the completed view! :) Keeping it simple and not adding yet another view.

[Compizfox]

Seconding this.

Maybe we just show cancelled tasks in the completed view. Even if they aren't really completed, they are similar since for both completed and cancelled tasks there is nothing left to do.

I was going to propose exactly this! :)

If I'm not mistaking, the Cancelled status doesn't do anything right now. Cancelled tasks show up exactly the same way as Needs Action tasks, whereas I would expect them to be more like Completed tasks.

Right now I can sort of get the behaviour I would like by first completing a task, and then changing its status to Cancelled. But that requires two actions and is rather unintuitive. Another catch is that completing a task forces its progression to 100%, which does not make sense if a task is cancelled.

[dargmuesli]

I took a quick look at this project's source and created a PR (#1418) that might already be enough for this to be resolved. I just currently don't have the time to setup actual testing. Would be great if someone else could check this out an give feedback! :)

[raimund-schluessler]

You can checkout a test version for this change in #1553 (comment)