-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat cancelled tasks as completed #1553
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
+ Coverage 32.32% 32.33% +0.01%
==========================================
Files 55 55
Lines 2803 2814 +11
Branches 528 532 +4
==========================================
+ Hits 906 910 +4
- Misses 1758 1762 +4
- Partials 139 142 +3 |
@dargmuesli I packed a release, so you can test the changes. Please test it well and make sure everything makes sense and is consistent. |
721c2a2
to
44cfb34
Compare
I manually installed the |
44cfb34
to
96a8a18
Compare
Resolves #1060. Signed-off-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
Signed-off-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
96a8a18
to
07ce0d9
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
With this PR we treat cancelled tasks as completed, so they don't show up as still to do. This resolves #1060.
This PR supersedes #1418.
Todo: