Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] ci(cypress): Fix selectors for new file picker #4680

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 14, 2023

Fix CI after new file picker got merged

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr juliusknorr changed the title ci(cypress): Fix selectors for new file picker [stable27] ci(cypress): Fix selectors for new file picker Aug 14, 2023
@cypress
Copy link

cypress bot commented Aug 14, 2023

Passing run #11755 ↗︎

0 148 2 0 Flakiness 0

Details:

[stable27] ci(cypress): Fix selectors for new file picker
Project: Text Commit: cbfc41677e
Status: Passed Duration: 04:32 💡
Started: Aug 18, 2023 4:42 PM Ended: Aug 18, 2023 4:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this.
💚

@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 46dbe16 into stable27 Aug 18, 2023
42 checks passed
@juliusknorr juliusknorr deleted the cypress/filepicker-27 branch August 18, 2023 17:02
@juliusknorr
Copy link
Member Author

/backport to main

@juliusknorr
Copy link
Member Author

Needs a forward port once the file picker is also merged on server master

@backportbot-nextcloud
Copy link

The backport to main failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout main
git pull origin main

# Create the new backport branch
git checkout -b fix/foo-main

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-main

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr juliusknorr mentioned this pull request Aug 21, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants