Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old link when editing #5690

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Apr 15, 2024

Fixes #5516

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt linked an issue Apr 15, 2024 that may be closed by this pull request
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Apr 16, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Apr 16, 2024
@max-nextcloud
Copy link
Collaborator

The current change works well when only changing a single link in a paragraph.
There are two more scenarios that would be good to account for:

Link in a paragraph

Find more information on https://nextcloud.com as usual.

-> should only change the link.

Link with custom text

More informarion

-> should only change the href.

@max-nextcloud max-nextcloud self-assigned this Apr 17, 2024
@max-nextcloud max-nextcloud force-pushed the fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link branch from 2d91369 to 95cc248 Compare April 17, 2024 13:48
Signed-off-by: Max <max@nextcloud.com>
It is a proper e2e test driving the ui.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link branch from 10bfdeb to 35f1d07 Compare April 17, 2024 14:17
Signed-off-by: Max <max@nextcloud.com>
This way we do not hand in the active state
and avoid inconsistencies.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Updating the URL of a link via toolbar menu splits the link
4 participants