Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old link when editing #5690

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

remove old link when editing #5690

wants to merge 7 commits into from
+153 −19

Commits on Apr 15, 2024

  1. remove old link when editing 

    Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
    @grnd-alt
    grnd-alt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    48f2347 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. refactor(links): add insertOrSetLink command 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    177e3e0 View commit details
    Browse the repository at this point in the history

  2. refactor(cy): move Links.spec.js into e2e folder 

    It is a proper e2e test driving the ui.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    16c2511 View commit details
    Browse the repository at this point in the history

  3. test(cy): initial test for the link mark

    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    35f1d07 View commit details
    Browse the repository at this point in the history

  4. test(cy): adjust import path in moved Links.spec.js 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d705663 View commit details
    Browse the repository at this point in the history

  5. refactor(link): use isMarkActive in insertOrSetLink 

    This way we do not hand in the active state
and avoid inconsistencies.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2a26029 View commit details
    Browse the repository at this point in the history

  6. test(cy): add some failing tests for insertOrSetLink 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f9e4df3 View commit details
    Browse the repository at this point in the history