[stable25] Fix fullscreen and button style #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
bug
|
/compile amend / |
":deep()" was introduced in Vue 3, although it can be used in Vue 2 too if vue-loader >= 5.10.0. However, in stable25 the viewer is using Vue 2 with vue-loader 5.9.8, so ":deep()" has no effect and therefore the styles for fullscreen mode and buttons were not applied. Given that the change from "::v-deep" to ":deep()" was done in a recent backport and that, except for security fixes, the dependencies are not bumped in stable versions "::v-deep" is used again instead of bumping the vue-loader version. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix-fullscreen-and-button-style-in-stable25
branch
from
982bca5
to
1c41bbe
Compare
skjnldsv
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #1804 (viewer 25.0.9)
:deep()was introduced in Vue 3, although it can be used in Vue 2 too if vue-loader >= 5.10.0 (as can be seen in the commit that made the change in master). However, in stable25 the viewer is using Vue 2 with vue-loader 5.9.8, so:deep()has no effect and therefore the styles for fullscreen mode and buttons were not applied.Given that the change from
::v-deepto:deep()was done in a recent backport and that, except for security fixes, the dependencies are not bumped in stable versions::v-deepis used again instead of bumping the vue-loader version.