Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix fullscreen and button style #1830

Merged
merged 1 commit into from
Aug 1, 2023

Commits on Jul 26, 2023

  1. Fix fullscreen and button style

    ":deep()" was introduced in Vue 3, although it can be used in Vue 2 too
    if vue-loader >= 5.10.0. However, in stable25 the viewer is using Vue 2
    with vue-loader 5.9.8, so ":deep()" has no effect and therefore the
    styles for fullscreen mode and buttons were not applied.
    
    Given that the change from "::v-deep" to ":deep()" was done in a recent
    backport and that, except for security fixes, the dependencies are not
    bumped in stable versions "::v-deep" is used again instead of bumping
    the vue-loader version.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    danxuliu authored and nextcloud-command committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    1c41bbe View commit details
    Browse the repository at this point in the history