Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise documentation for hybrid cloud execution #5362

Merged

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Oct 3, 2024

This harmonises the hybrid cloud documentation of the three major cloud providers. This just makes the language consistent across all three.

It supercedes #5361 and may go some of the way to resolving #2984.

Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot adamrtalbot requested a review from a team as a code owner October 3, 2024 17:10
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 19bca6f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/671265a2c0b2340008736a52
😎 Deploy Preview https://deploy-preview-5362--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Copy link
Contributor

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding missing link and moving note to admonition

docs/azure.md Outdated Show resolved Hide resolved
docs/aws.md Outdated Show resolved Hide resolved
docs/aws.md Outdated Show resolved Hide resolved
docs/azure.md Outdated Show resolved Hide resolved
docs/google.md Outdated Show resolved Hide resolved
docs/google.md Outdated Show resolved Hide resolved
Co-authored-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@pditommaso
Copy link
Member

There are a bunch conflicts. @adamrtalbot can you please have a look?

Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot
Copy link
Collaborator Author

@pditommaso done

docs/aws.md Outdated Show resolved Hide resolved
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
@pditommaso pditommaso merged commit a69407d into nextflow-io:master Oct 18, 2024
12 checks passed
@adamrtalbot adamrtalbot deleted the 2984_hybrid_cloud_documentation branch October 18, 2024 15:25
alberto-miranda pushed a commit to alberto-miranda/nextflow that referenced this pull request Nov 19, 2024
… [ci fast]


Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Co-authored-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants