Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

127-file multiselection action #208

Closed

Conversation

TSI-kavitasonawane
Copy link

This PR contains the following changes:
File action button behaviour changes:

  • We now show more single actions depending on the viewport size in the table header beginning from the first option in the dropdown.
  • We add a new option called "Cancel" (ger: Abbrechen") which will remove any selection (just remove selection, not the files of course).
  • We right align the Actions button.
  • We will show every option in the action button dropdown. It doesnt matter which option is also shown in the table header.
  • We add a new label called "All".
  • on S: we hide the label "All" according to the screen design

@TSI-kavitasonawane TSI-kavitasonawane added the custom MagentaCLOUD customisation label Apr 21, 2023
@tsdicloud
Copy link
Member

tsdicloud commented Apr 26, 2023

Please check whether parts of the change ("multiselect") are useful to add to Nextcloud server upstream.
If so, pls separate these common changes from Telekom specific layout changes in separate CR and upstream
the common part as PR to Nextcloud.

@tsdicloud
Copy link
Member

Please check whether javascript changes can be done non-invasive in a separate package to avoid change on NC standard

@tsdicloud
Copy link
Member

Generated css checked in, but shouldn't

@TSI-kavitasonawane
Copy link
Author

Please check whether parts of the change ("multiselect") are useful to add to Nextcloud server upstream. If so, pls separate these common changes from Telekom specific layout changes in separate CR and upstream the common part as PR to Nextcloud.

We had already raised as PR for upstream to nextcloud but they have closed it ..
so still we need to try to upstream these feature changes ??
PR link: nextcloud#28834

@TSI-kavitasonawane
Copy link
Author

Generated css checked in, but shouldn't

I am working on it.

@TSI-kavitasonawane TSI-kavitasonawane force-pushed the nmcfeat/127-file-multiselection-action branch from 59b4a82 to 808f333 Compare April 27, 2023 13:30
@TSI-kavitasonawane
Copy link
Author

I have renamed this branch with same changes to follow the new branch naming-conventions for new delivery model.
so hence raising new PR by closing this one.

New PR link - #217

@tsdicloud tsdicloud deleted the nmcfeat/127-file-multiselection-action branch July 14, 2023 12:32
@tsdicloud tsdicloud added iteration25 Experimental release 25 (review material only) and removed custom MagentaCLOUD customisation labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iteration25 Experimental release 25 (review material only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants