Stop quoting TSV outputs from augur curate #1493
Conversation
Shows the undesired behavior with internal quotes described in <#1312> comes from the `write_records_to_tsv` function.
According to TSV specs,¹ there are no restrictions on special characters other than tabs are not allowed in a field. This is different from the CSV specs,² which require double quotes around fields that contain special characters. Since this function only produces TSVs, follow the TSV specs and stop adding quotes. Resolves <#1312> ¹ <https://www.iana.org/assignments/media-types/text/tab-separated-values> ² <https://datatracker.ietf.org/doc/html/rfc4180#page-2>
joverlee521
force-pushed
the
curate-internal-quotes
branch
from
eea9765
to
23b80e5
Compare
|
Rebased on to master to prevent merge conflicts in the changelog and added a changelog entry. |
|
@genehack how did you approve a merged PR?? I haven't seen that option so I use a ✅ comment instead... |
Huh, gh cli allows it: cli/cli#5038 (I just tried it on #1500) |
I had it open in a tab from friday and didn't realize it had been merged when I approved it — the tab I was looking at said "OPEN" still! |
Oh neat! Maybe I'll use that in the future... or just stick to the emoji if I'm lazy |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 70 70
Lines 7694 7694
Branches 1887 1887
=======================================
Hits 5321 5321
Misses 2087 2087
Partials 286 286 ☔ View full report in Codecov by Sentry. |
Description of proposed changes
Resolves #1312 by never quoting output fields from
write_records_to_tsv.See commits for details.
Checklist