Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop quoting TSV outputs from augur curate #1493

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Commits on Jun 27, 2024

  1. test_metadata: show current behavior with internal quotes

    Shows the undesired behavior with internal quotes described in
    <#1312> comes from the
    `write_records_to_tsv` function.
    joverlee521 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f0bd23e View commit details
    Browse the repository at this point in the history
  2. write_records_to_tsv: Stop quoting output TSV

    According to TSV specs,¹ there are no restrictions on special characters
    other than tabs are not allowed in a field. This is different from the
    CSV specs,² which require double quotes around fields that contain
    special characters.
    
    Since this function only produces TSVs, follow the TSV specs and stop
    adding quotes.
    
    Resolves <#1312>
    
    ¹ <https://www.iana.org/assignments/media-types/text/tab-separated-values>
    ² <https://datatracker.ietf.org/doc/html/rfc4180#page-2>
    joverlee521 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    915672e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d02b11b View commit details
    Browse the repository at this point in the history
  4. Update changelog

    joverlee521 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    23b80e5 View commit details
    Browse the repository at this point in the history