Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nextstrain/ingest #5

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 12, 2023

Description of proposed changes

Begin usage of centralized ingest scripts and add details on how to pull new updates from the central repo.

Note that this repo only uses one of the scripts pulled from the central ingest repo.

Testing

  • Ingest workflow runs locally without errors

@victorlin victorlin self-assigned this Jul 12, 2023
@victorlin victorlin changed the title Use nextstrain/ingest (git subrepo) Use nextstrain/ingest (git subrepo clone) Jul 12, 2023
@victorlin victorlin force-pushed the victorlin/add-ingest-vendored-git-subrepo branch from 67a3cfd to 45be224 Compare August 1, 2023 18:11
@victorlin victorlin changed the title Use nextstrain/ingest (git subrepo clone) Use nextstrain/ingest Aug 1, 2023
@victorlin victorlin force-pushed the victorlin/add-ingest-vendored-git-subrepo branch from 45be224 to 2180021 Compare August 1, 2023 23:59
@jameshadfield jameshadfield mentioned this pull request Aug 7, 2023
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a draft but I think it can (and should!) be merged. Thanks!

…/vendored

subrepo:
  subdir:   "ingest/vendored"
  merged:   "5d90818"
upstream:
  origin:   "https://github.com/nextstrain/ingest"
  branch:   "main"
  commit:   "5d90818"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
The previous commit was created by the following command:

    git subrepo clone https://github.com/nextstrain/ingest ingest/vendored

Add a section in the README on how to use this directory in the future.
Remove the copies in this repo and update references.

The centralized script is functionally identical.
@victorlin victorlin force-pushed the victorlin/add-ingest-vendored-git-subrepo branch from 2180021 to 03e1820 Compare August 8, 2023 18:28
@victorlin victorlin marked this pull request as ready for review August 8, 2023 18:30
@victorlin victorlin merged commit 14d6bbc into master Aug 8, 2023
@victorlin victorlin deleted the victorlin/add-ingest-vendored-git-subrepo branch August 9, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants