Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing pathogen repos to vendor ingest scripts #9

Closed
7 tasks done
joverlee521 opened this issue Jul 27, 2023 · 4 comments
Closed
7 tasks done

Update existing pathogen repos to vendor ingest scripts #9

joverlee521 opened this issue Jul 27, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Jul 27, 2023

Context

Depends on #3

Once we've decided on how to vendor the centralized ingest scripts, we should update the existing pathogen builds to use the ingest scripts.

This will probably be better to do as an iterative process that happens in parallel with #1.

Description

Repos that should be updated to vendor the ingest scripts:

The following repos have WIP PRs for adding ingest to their workflows that can be updated to vendor the scripts:

@joverlee521 joverlee521 added the enhancement New feature or request label Jul 27, 2023
@victorlin
Copy link
Member

victorlin commented Jul 28, 2023

To start things off, I'm going to try this for the monkeypox repo: nextstrain/mpox#164

@victorlin victorlin self-assigned this Jul 28, 2023
@victorlin
Copy link
Member

Is the ncov repo worth including in this initial effort? It has no use for the ingest-specific scripts, but does use upload-to-s3+sha256sum.

From 690fa99:

The copy of this script in ncov² has diverged enough that I think it's not worth it to incorporate changes here.
² https://github.com/nextstrain/ncov/blob/ba9953f8a61d239176e960b9b2efb925b5dff84b/scripts/upload-to-s3

I assume ncov should keep using its own copy of upload-to-s3. That leaves sha256sum as the only script to switch over to. This is what that would look like: nextstrain/ncov@fcd7327...79af5ca

The added subrepo complexity in the ncov repo just for the sha256sum script is not worth it to me.

@joverlee521
Copy link
Contributor Author

The added subrepo complexity in the ncov repo just for the sha256sum script is not worth it to me.

Agreed! We can skip the ncov repo.

@victorlin
Copy link
Member

Assigning @j23414 for dengue and zika.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants