Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles/nextstrain-public: Update build/auspice names #153

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

joverlee521
Copy link
Contributor

Description of proposed changes

We will be changing the URLs for seasonal flu from nextstrain.org/flu/seasonal/... to nextstrain.org/seasonal-flu/... to match changes for avian-flu.

This commit changes the build_name and auspice_name for the nextstrain-public builds to reflect this change.

Related issue(s)

Resolves #152

Checklist

  • Checks pass

We will be changing the URLs for seasonal flu from
`nextstrain.org/flu/seasonal/...` to `nextstrain.org/seasonal-flu/...`
to match changes for avian-flu.

This commit changes the build_name and auspice_name for the
nextstrain-public builds to reflect this change.
@joverlee521
Copy link
Contributor Author

joverlee521 commented Feb 20, 2024

Ah, will need to update AWS IAM permissions to allow the uploads to seasonal-flu* prefix.

Edit: Updated the NextstrainSeasonalFluUploader policy to allow reading/writing the seasonal-flu* prefix.

@joverlee521
Copy link
Contributor Author

Running test builds in https://github.com/nextstrain/seasonal-flu/actions/runs/7981622939.

The test builds should be deployed with the new Auspice JSON names seasonal-flu_*.json, but won't be visible on nextstrain.org (yet). The manifest_core.json is being updated by @lmoncla on the avian-flu-restructure branch in the nextstrain.org repo.

@joverlee521
Copy link
Contributor Author

Avian flu CI changes in nextstrain/avian-flu#12 prompted me to take another look here.
It's a nonissue here because the CI uses a completely separate profile

build-args: --configfile profiles/ci/builds.yaml -p

@joverlee521 joverlee521 marked this pull request as ready for review April 23, 2024 19:13
@joverlee521
Copy link
Contributor Author

Merging ahead of nextstrain/nextstrain.org#811.

@joverlee521 joverlee521 merged commit c04e599 into master Apr 23, 2024
11 checks passed
@joverlee521 joverlee521 deleted the update-nextstrain-public branch April 23, 2024 19:16
@joverlee521
Copy link
Contributor Author

Instead of running builds again, I've just copied over the flu_seasonal_*.json files to seasonal-flu_*.json using https://gist.github.com/joverlee521/dedba0a47e7fd04ef708c470df802769.

The builds that we will trigger in our new updates on Thursday will upload to the new paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename public nextstrain builds to seasonal-flu
1 participant