Update domain model to AVPRIndex package, add WIP AVPRClient support #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kMutagene
approved these changes
Mar 5, 2024
| @@ -22,6 +23,8 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Fake.DotNet.Cli" Version="[6.0.0]" /> | |||
| <PackageReference Include="FsHttp" Version="[11.0.0]" /> | |||
| <PackageReference Include="AVPRClient" Version="[0.0.2]" /> | |||
There was a problem hiding this comment.
Reminder to bump these in the final PR
| open System.Net.Http | ||
|
|
||
| type AVPRAPI () = | ||
| member private this.BaseUri = Uri("https://avpr.nfdi4plants.org") |
There was a problem hiding this comment.
I'd prefer these to be refactored into Globals namespace. I am also quite sure that the default base url is already set to exactly this url when you call the client constructor
| @@ -28,6 +28,7 @@ | |||
| <PackageReference Include="Expecto" Version="[9.0.4]" /> | |||
| <PackageReference Include="Spectre.Console" Version="0.48.0" /> | |||
| <PackageReference Include="Spectre.Console.CLI" Version="0.48.0" /> | |||
| <PackageReference Include="AVPRIndex" Version="[0.0.2]" /> | |||
There was a problem hiding this comment.
most likely not needed because of transient dependency of ARCValidationPackages lib
| Affiliation = "University of Nowhere", | ||
| AffiliationLink = "https://nowhere.edu" | ||
| let author1 = new Author() | ||
| let author2 = new Author() |
There was a problem hiding this comment.
You'll have Author.create with Index package
There was a problem hiding this comment.
yes i know, this was from before those functions were included
| // email = "jj@d.com", | ||
| // Affiliation = "University of Somewhere", | ||
| // AffiliationLink = "https://somewhere.edu" | ||
| //) | ||
| |], | ||
| Tags = [| |
kMutagene
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AVPR Client as an option for package handling to arc validate. It will be added alongside the github API handling, allowing usage of both. It also integrates the Domain section from the AVRPIndex