-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update domain model to AVPRIndex package, add WIP AVPRClient support #90
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e05600
add avpr client and index
caroott 0310b55
Merge branch 'nfdi4plants:main' into apiNew
caroott 3bffce0
switch to AVPRIndex domain, rename ARC- to CachedValidationPackage
caroott b86a0ff
merge changes
caroott eabf276
adapt test for new AVPRIndex package
caroott 22a52e8
correct type
caroott fa8a949
fix lineendings and type reference
caroott 2ff0ed6
separate package cache in preview and release
caroott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
namespace ARCValidationPackages | ||
|
||
open AVPRClient | ||
open ARCValidationPackages | ||
open AVPRIndex | ||
open System | ||
open System.Net.Http | ||
|
||
type AVPRAPI () = | ||
member private this.BaseUri = Uri("https://avpr.nfdi4plants.org") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer these to be refactored into Globals namespace. I am also quite sure that the default base url is already set to exactly this url when you call the client constructor |
||
member private this.HttpClienHandler = new HttpClientHandler (UseCookies = false) | ||
member private this.HttpClient = new HttpClient(this.HttpClienHandler, true, BaseAddress=this.BaseUri) | ||
member this.Client = AVPRClient.Client(this.HttpClient) | ||
member this.GetAllPackages (): ValidationPackage [] = | ||
this.Client.GetAllPackagesAsync(System.Threading.CancellationToken.None) | ||
|> Async.AwaitTask | ||
|> Async.RunSynchronously | ||
|> Seq.toArray | ||
member this.GetPackageByName (packageName: string): ValidationPackage = | ||
this.Client.GetLatestPackageByNameAsync(packageName) | ||
|> Async.AwaitTask | ||
|> Async.RunSynchronously | ||
member this.GetPackageByNameAndVersion (packageName: string) (version: string): ValidationPackage = | ||
this.Client.GetPackageByNameAndVersionAsync(packageName, version) | ||
|> Async.AwaitTask | ||
|> Async.RunSynchronously | ||
|
||
//member this.downloadPackageScript (packageIndex: ValidationPackageIndex) = | ||
|
||
// let validationPackage = | ||
// this.GetPackageByNameAndVersion | ||
// packageIndex.Metadata.Name | ||
// (ValidationPackageMetadata.getSemanticVersionString packageIndex.Metadata) | ||
// Text.Encoding.UTF8.GetString validationPackage.PackageContent |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to bump these in the final PR