feat: api support for ipfs-cluster@1.0 #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPFS Cluster v1 release has much improved perf, and some breaking API changes. In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API. see: #1736 see: https://github.com/nftstorage/ipfs-cluster/releases/tag/v5.0.0 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <oli@tableflip.io>
Deploying with
|
| Latest commit: |
bb7e144
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b0a615e.nft-storage-1at.pages.dev |
|
@gobengo CI is failing on this PR with It looks like this was introduced with #1698 |
the secrets context is not available in `jobs.<job id>.if` see: https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <oli@tableflip.io>
vasco-santos
reviewed
Apr 8, 2022
|
@olizilla big apologies! I should have tested all the workflows since I touched them. Is there a better way than briefly updating some file in each project? Here is another approach that might work? #1791 @vasco-santos if you're still looking, wdyt of that? |
This was referenced Apr 8, 2022
I added the conditional to make PRs pass this check even if coming from forks that don't have that variable defined. I had a PR from my fork that was failing due to it. I think something else is going on where the existing secret.CF_API_TOKEN is defined in this repo but erroring against CF API. i.e. it's potentially invalid (or CF API is rejecting it, but that seems less likely). |
* remove secrets check in if: in github api workflow * touch api package to trigger github action * ci(api): Try another way of deploy-dev not breaking if CF_API_TOKEN is not set * ci(api): temporarily make deploy-dev not need test * Revert "touch api package to trigger github action" This reverts commit 1f110d1. * Revert "ci(api): temporarily make deploy-dev not need test" This reverts commit d09c94f. * feat: api support for ipfs-cluster@1.0 The IPFS Cluster v1 release has much improved perf, and some breaking API changes. In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API. see: #1736 see: https://github.com/nftstorage/ipfs-cluster/releases/tag/v5.0.0 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <oli@tableflip.io> Co-authored-by: Oli Evans <oli@tableflip.io>
alanshaw
pushed a commit
that referenced
this pull request
Apr 12, 2022
Same as web3-storage/web3.storage#1241 to go together with #1789
alanshaw
pushed a commit
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPFS Cluster v1 release has much improved perf, and some breaking API changes.
In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API.
CI was failing for the API, so this PR includes a change to that workflow to fix that.
After merging this PR
see: #1736
see: https://github.com/nftstorage/ipfs-cluster/releases/tag/v5.0.0
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans oli@tableflip.io