Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure api workflow works on PRs from forks #1791

Closed
wants to merge 7 commits into from

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Apr 8, 2022

Alternatives:

Motivation:

Inspiration

Strategy:

  • You can't if on secrets, but you can on env, so pass the secret as an env

Test:

Open Questions

@gobengo gobengo changed the title 1649436569 fix api workflow ci: 1649436569 fix api workflow Apr 8, 2022
@gobengo gobengo marked this pull request as ready for review April 8, 2022 17:22
@gobengo gobengo changed the title ci: 1649436569 fix api workflow ci: ensure api workflow works on PRs from forks Apr 8, 2022
The IPFS Cluster v1 release has much improved perf, and some breaking API changes.

In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API.

see: nftstorage#1736
see: https://github.com/nftstorage/ipfs-cluster/releases/tag/v5.0.0

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <oli@tableflip.io>
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gobengo let's merge this into Oli's PR (your other PR). Oli's PR is a breaking change that is part of tomorrow's maintenance in nft.storage to update production cluster

@gobengo gobengo closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants