Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary type assertion #6479

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Static check reported this unnessary type assertion, removed as its always a runtime.Object

internal/certmanager/test_files/reactors.go:49:14: type assertion to the same type: createAction.GetObject() already has type runtime.Object (S1040)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner September 23, 2024 16:08
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.21%. Comparing base (eba387b) to head (8f7d88a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/certmanager/test_files/reactors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6479      +/-   ##
==========================================
- Coverage   53.24%   53.21%   -0.03%     
==========================================
  Files          85       85              
  Lines       16015    16016       +1     
==========================================
- Hits         8527     8523       -4     
- Misses       7082     7085       +3     
- Partials      406      408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) September 23, 2024 16:15
@j1m-ryan j1m-ryan merged commit fdedba6 into main Sep 23, 2024
81 checks passed
@j1m-ryan j1m-ryan deleted the chore/fix-staticcheck-type-assertion-error branch September 23, 2024 16:47
@pdabelf5 pdabelf5 added tests Pull requests that update tests and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title Remove unnessary type assertion Remove unnecessary type assertion Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants