Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary type assertion #6479

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove unnecessary type assertion #6479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1e192
remove unnessary type assertion
j1m-ryan Sep 23, 2024
8f7d88a
Merge branch 'main' into chore/fix-staticcheck-type-assertion-error
j1m-ryan Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions internal/certmanager/test_files/reactors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@
if !ok {
return
}
obj, ok := createAction.GetObject().(runtime.Object)
if !ok {
t.Errorf("object passed to Create does not implement runtime.Object")
}

obj := createAction.GetObject()

Check warning on line 49 in internal/certmanager/test_files/reactors.go

View check run for this annotation

Codecov / codecov/patch

internal/certmanager/test_files/reactors.go#L49 

Added line #L49 was not covered by tests
if !reflect.DeepEqual(obj, expectedObj) {
t.Errorf("expected %+v to equal %+v", obj, expectedObj)
}
Expand Down
Loading