Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds info on setting up host network access #2263

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

fardarter
Copy link
Contributor

@fardarter fardarter commented Jul 19, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: The documentation on getting a local cluster up in kind could be more friendly.

Solution: Have updated the docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE


@fardarter fardarter requested review from a team as code owners July 19, 2024 09:20
Copy link

nginx-bot bot commented Jul 19, 2024

Hi @fardarter! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
See Linking a pull request to an issue and our Pull Request Guidelines for more information.

@nginx-bot nginx-bot bot added the community label Jul 19, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2024
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes LGTM.

site/content/installation/running-on-kind.md Outdated Show resolved Hide resolved
@ADubhlaoich
Copy link
Contributor

pre-commit.ci autofix

@fardarter fardarter force-pushed the patch-1 branch 2 times, most recently from 4783174 to 15a35e0 Compare July 24, 2024 05:53
@fardarter fardarter requested a review from kate-osborn July 24, 2024 06:09
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (e1116fb) to head (db791fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) July 24, 2024 19:10
@sjberman sjberman merged commit ea485b4 into nginxinc:main Jul 24, 2024
37 checks passed
@kate-osborn kate-osborn mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants