Skip to content

Commit

Permalink
refactor: remove jquery, nhnent -> nhn (fix #23, #21) (#24) (#31)
Browse files Browse the repository at this point in the history
* refactor: remove jquery, nhnent -> nhn (fix #23, #21)

* refactor: apply tui-dom

* chore: apply code review

* chore: apply code review - 2

* chore: apply code review - 3

* fix: typo
  • Loading branch information
seonim-ryu authored and 한정 committed Aug 1, 2019
1 parent d0ea48f commit a19909e
Show file tree
Hide file tree
Showing 23 changed files with 1,632 additions and 1,556 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ module.exports = {
"env": {
"browser": true,
"jasmine": true,
"jquery": true,
"commonjs": true
},
"globals": {
Expand Down
46 changes: 23 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# TOAST UI Component : Time Picker
> Component that selects specific time.
[![GitHub release](https://img.shields.io/github/release/nhnent/tui.time-picker.svg)](https://github.com/nhnent/tui.time-picker/releases/latest)
[![GitHub release](https://img.shields.io/github/release/nhn/tui.time-picker.svg)](https://github.com/nhn/tui.time-picker/releases/latest)
[![npm](https://img.shields.io/npm/v/tui-time-picker.svg)](https://www.npmjs.com/package/tui-time-picker)
[![GitHub license](https://img.shields.io/github/license/nhnent/tui.time-picker.svg)](https://github.com/nhnent/tui.time-picker/blob/production/LICENSE)
[![PRs welcome](https://img.shields.io/badge/PRs-welcome-ff69b4.svg)](https://github.com/nhnent/tui.project-name/labels/help%20wanted)
[![code with hearth by NHN](https://img.shields.io/badge/%3C%2F%3E%20with%20%E2%99%A5%20by-NHN-ff1414.svg)](https://github.com/nhnent)
[![GitHub license](https://img.shields.io/github/license/nhn/tui.time-picker.svg)](https://github.com/nhn/tui.time-picker/blob/production/LICENSE)
[![PRs welcome](https://img.shields.io/badge/PRs-welcome-ff69b4.svg)](https://github.com/nhn/tui.project-name/labels/help%20wanted)
[![code with hearth by NHN](https://img.shields.io/badge/%3C%2F%3E%20with%20%E2%99%A5%20by-NHN-ff1414.svg)](https://github.com/nhn)


## 🚩 Table of Contents
Expand Down Expand Up @@ -45,7 +45,7 @@ var options = {
var instance = new TimePicker(container, options);
```

Or, include [`tui-code-snippet`](https://github.com/nhnent/tui.code-snippet)(**v1.5.0** or **later**) and then immediately write the options as follows:
Or, include [`tui-code-snippet`](https://github.com/nhn/tui.code-snippet)(**v1.5.0** or **later**) and then immediately write the options as follows:

```js
tui.usageStatistics = false;
Expand All @@ -68,9 +68,9 @@ tui.usageStatistics = false;


## 🐾 Examples
* [Basic](https://nhnent.github.io/tui.date-picker/latest/tutorial-example01-basic) : Example of using default options.
* [Using meridiem](https://nhnent.github.io/tui.time-picker/latest/tutorial-example01-basic) : An example of selecting AM/PM(Meridiem).
* [Using step](https://nhnent.github.io/tui.time-picker/latest/tutorial-example04-i18n) : Example of selecting the time for a specific interval.
* [Basic](https://nhn.github.io/tui.date-picker/latest/tutorial-example01-basic) : Example of using default options.
* [Using meridiem](https://nhn.github.io/tui.time-picker/latest/tutorial-example01-basic) : An example of selecting AM/PM(Meridiem).
* [Using step](https://nhn.github.io/tui.time-picker/latest/tutorial-example04-i18n) : Example of selecting the time for a specific interval.

More examples can be found on the left sidebar of each example page, and have fun with it.

Expand Down Expand Up @@ -125,8 +125,8 @@ tui.time-picker/
```

### Download Source Files
* [Download bundle files](https://github.com/nhnent/tui.time-picker/tree/production/dist)
* [Download all sources for each version](https://github.com/nhnent/tui.time-picker/releases)
* [Download bundle files](https://github.com/nhn/tui.time-picker/tree/production/dist)
* [Download all sources for each version](https://github.com/nhn/tui.time-picker/releases)


## 🔨 Usage
Expand Down Expand Up @@ -158,7 +158,7 @@ var TimePicker = require('tui-time-picker'); /* CommonJS */
import TimePicker from 'tui-time-picker'; /* ES6 */
```

You can create an instance with [options](https://nhnent.github.io/tui.time-picker/latest/TimePicker) and call various APIs after creating an instance.
You can create an instance with [options](https://nhn.github.io/tui.time-picker/latest/TimePicker) and call various APIs after creating an instance.

``` javascript
var container = document.getElementById('tui-time-picker-container');
Expand All @@ -167,7 +167,7 @@ var instance = new TimePicker(container, { ... });
instance.getHour();
```

For more information about the API, please see [here](https://nhnent.github.io/tui.time-picker/latest/TimePicker).
For more information about the API, please see [here](https://nhn.github.io/tui.time-picker/latest/TimePicker).


## 🔧 Pull Request Steps
Expand Down Expand Up @@ -216,25 +216,25 @@ For more information on PR's step, please see links of Contributing section.


## 📙 Documents
* [Getting Started](https://github.com/nhnent/tui.time-picker/blob/production/docs/getting-started.md)
* [Tutorials](https://github.com/nhnent/tui.time-picker/tree/production/docs)
* [APIs](https://nhnent.github.io/tui.time-picker/latest)
* [Getting Started](https://github.com/nhn/tui.time-picker/blob/production/docs/getting-started.md)
* [Tutorials](https://github.com/nhn/tui.time-picker/tree/production/docs)
* [APIs](https://nhn.github.io/tui.time-picker/latest)

You can also see the older versions of API page on the [releases page](https://github.com/nhnent/tui.time-picker/releases).
You can also see the older versions of API page on the [releases page](https://github.com/nhn/tui.time-picker/releases).


## 💬 Contributing
* [Code of Conduct](https://github.com/nhnent/tui.time-picker/blob/production/CODE_OF_CONDUCT.md)
* [Contributing guideline](https://github.com/nhnent/tui.time-picker/blob/production/CONTRIBUTING.md)
* [Issue guideline](https://github.com/nhnent/tui.time-picker/blob/production/docs/ISSUE_TEMPLATE.md)
* [Commit convention](https://github.com/nhnent/tui.time-picker/blob/production/docs/COMMIT_MESSAGE_CONVENTION.md)
* [Code of Conduct](https://github.com/nhn/tui.time-picker/blob/production/CODE_OF_CONDUCT.md)
* [Contributing guideline](https://github.com/nhn/tui.time-picker/blob/production/CONTRIBUTING.md)
* [Issue guideline](https://github.com/nhn/tui.time-picker/blob/production/docs/ISSUE_TEMPLATE.md)
* [Commit convention](https://github.com/nhn/tui.time-picker/blob/production/docs/COMMIT_MESSAGE_CONVENTION.md)


## 🔩 Dependency
* [tui-code-snippet](https://github.com/nhnent/tui.code-snippet) >=1.5.0
* [jquery](https://jquery.com/) >=1.11.0
* [tui-code-snippet](https://github.com/nhn/tui.code-snippet) >=1.5.0
* [tui-dom](https://github.com/nhn/tui.dom) >=3.0.0


## 📜 License

This software is licensed under the [MIT](https://github.com/nhnent/tui.time-picker/blob/production/LICENSE) © [NHN](https://github.com/nhnent).
This software is licensed under the [MIT](https://github.com/nhn/tui.time-picker/blob/production/LICENSE) © [NHN](https://github.com/nhn).
5 changes: 2 additions & 3 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@
"examples",
"src",
"test",
"jsdoc.conf.json",
"karma.conf.js",
"webpack.config.js",
"package.json",
"package-lock.json"
],
"dependencies": {
"jquery": "^1.11.0",
"tui-code-snippet": "^1.5.0"
"tui-code-snippet": "^1.5.0",
"tui-dom": "^3.0.0"
}
}
4 changes: 2 additions & 2 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

## Documents

- [Code of Conducting](../CODE_OF_CONDUCTING.md)
- [Code of Conducting](../CODE_OF_CONDUCT.md)
- [Contributing Guide](../CONTRIBUTING.md)
- [Commit Message Convention](COMMIT_MESSAGE_CONVENTION.md)
- [API & Examples](https://nhnent.github.io/tui.time-picker/latest)
- [API & Examples](https://nhn.github.io/tui.time-picker/latest)
9 changes: 5 additions & 4 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### 1. Load dependency files
* Script - [jQuery](https://github.com/jquery/jquery) 1.11.0 or later
* Script - [tui-code-snippet](https://github.com/nhnent/tui.code-snippet) 1.2.5 or later
* Script - [tui-code-snippet](https://github.com/nhn/tui.code-snippet) 1.5.0 or later
* Script - [tui-dom](https://github.com/nhn/tui.dom) 3.0.0 or later
> If your project should support IE8, please use `tui-dom.js`, not `tui-dom.min.js`.
```html
<html>
Expand All @@ -10,8 +11,8 @@
</head>
<body>
....
<script type="text/javascript" src="jquery.min.js"></script>
<script type="text/javascript" src="tui-code-snippet.min.js"></script>
<script type="text/javascript" src="tui-dom.min.js"></script>
<script type="text/javascript" src="tui-time-picker.min.js"></script>
....
</body>
Expand All @@ -32,4 +33,4 @@ var instance = new tui.TimePicker('#timepicker-wrapper', {
});
```

You can see the detail information at the [API & Examples](https://nhnent.github.io/tui.time-picker/latest)
You can see the detail information at the [API & Examples](https://nhn.github.io/tui.time-picker/latest)
2 changes: 1 addition & 1 deletion examples/example01-basic.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
</table>
</div>

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-time-picker.js"></script>
<script type="text/javascript" class="code-js">
var tpSelectbox = new tui.TimePicker('#timepicker-selectbox', {
Expand Down
2 changes: 1 addition & 1 deletion examples/example02-using-meridiem.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
</table>
</div>

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-time-picker.js"></script>
<script type="text/javascript" class="code-js">

Expand Down
2 changes: 1 addition & 1 deletion examples/example03-using-step.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
</table>
</div>

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-time-picker.js"></script>
<script type="text/javascript" class="code-js">

Expand Down
2 changes: 1 addition & 1 deletion examples/example04-i18n.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
</table>
</div>

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.min.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-time-picker.js"></script>
<script type="text/javascript" class="code-js">

Expand Down
31 changes: 0 additions & 31 deletions jsdoc.conf.json

This file was deleted.

Loading

0 comments on commit a19909e

Please sign in to comment.