Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong example link #21

Closed
dev-jonghoonpark opened this issue Mar 12, 2019 · 4 comments
Closed

wrong example link #21

dev-jonghoonpark opened this issue Mar 12, 2019 · 4 comments
Assignees
@heenakwag
Labels
Good First Issue 🙋‍♀️ 🙋‍♂️ Priority: Low
Milestone
1.6.0

Comments

@dev-jonghoonpark
Copy link

Basic example link should be 'https://nhnent.github.io/tui.time-picker/latest/tutorial-example01-basic'
not 'http://nhnent.github.io/tui.date-picker/latest/tutorial-example01-basic'

please fix :>
@jung-han
Copy link
Member

@chooco13 Thanks for issue! I'll fix it.

@c0bra
Copy link

c0bra commented Jun 14, 2019 •
edited
Loading

Still broken. Looks like nhnent was renamed to nhn.

@jung-han jung-han added this to the 1.6.0 milestone Jul 15, 2019
heenakwag added a commit that referenced this issue Jul 22, 2019
@heenakwag
refactor: remove jquery, nhnent -> nhn (fix #23, #21)
770a8f4
jung-han pushed a commit that referenced this issue Jul 25, 2019
@heenakwag
refactor: remove jquery, nhnent -> nhn (fix #23, #21) (#24)
7ae4be4 
* refactor: remove jquery, nhnent -> nhn (fix #23, #21)

* refactor: apply tui-dom

* chore: apply code review

* chore: apply code review - 2

* chore: apply code review - 3

* fix: typo
heenakwag added a commit that referenced this issue Jul 26, 2019
@heenakwag
Revert "refactor: remove jquery, nhnent -> nhn (fix #23, #21) (#24)"
c187e22 
This reverts commit 7ae4be4.
seonim-ryu pushed a commit that referenced this issue Aug 1, 2019
@heenakwag @seonim-ryu
refactor: remove jquery, nhnent -> nhn (fix #23, #21) (#24)
ed20078 
* refactor: remove jquery, nhnent -> nhn (fix #23, #21)

* refactor: apply tui-dom

* chore: apply code review

* chore: apply code review - 2

* chore: apply code review - 3

* fix: typo
jung-han pushed a commit that referenced this issue Aug 1, 2019
@seonim-ryu
refactor: remove jquery, nhnent -> nhn (fix #23, #21) (#24) (#31)
a19909e 
* refactor: remove jquery, nhnent -> nhn (fix #23, #21)

* refactor: apply tui-dom

* chore: apply code review

* chore: apply code review - 2

* chore: apply code review - 3

* fix: typo
@dev-jonghoonpark
Copy link
Author

Basic example link should be 'https://nhn.github.io/tui.time-picker/2.0.0/tutorial-example01-basic'
not 'https://nhn.github.io/tui.date-picker/4.0.0/tutorial-example01-basic'
current link is date-picker.

please fix ... again.... ;>

heenakwag added a commit that referenced this issue Aug 12, 2019
@heenakwag
docs: fix a wrong example link (fix: #21)
e493156
@heenakwag
Copy link
Member

@chooco13
I am sorry I misunderstood your issue. I fixed the link. Thanks for letting me know again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heenakwag heenakwag

Labels
Good First Issue 🙋‍♀️ 🙋‍♂️ Priority: Low
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
4 participants
@c0bra @dev-jonghoonpark @heenakwag @jung-han