Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side unary communication performance improvements #335

Merged
merged 54 commits into from
Jan 24, 2024
Merged

Client side unary communication performance improvements #335

merged 54 commits into from
Jan 24, 2024

Conversation

CPattar-NI
Copy link
Collaborator

Optimizing the copy path between LV and protobuf​ by eliminating data copy into temporary structures. Instead of the previously used "values" map to store the message data temporarily during the message parsing phase and then walking through the map to fill in the LV structure, we copy the message values directly into LV structures.

CPattar-NI and others added 30 commits October 9, 2023 12:18
@CPattar-NI
partially complete changes to templatize data structures
0040c4a
@CPattar-NI
not using the messagevalueclasses
8ab9c50
@CPattar-NI
resizing LVArray dynamically
55c7771
@CPattar-NI
resize array as and when required, template-specialization for uint64
4c2b942
@yash-ni
Chakith changes
7ab9a65
@yash-ni
updated gitignore to add build_bak
e9fb841
@yash-ni
Added variable check
5ef4159
@yash-ni
Merge branch 'remove-temp-structures' of https://github.com/yash-ni/g…
bc57257 
…rpc-labview into remove-temp-structures
@yash-ni
Added templates for basic datatypes
4a91451
@yash-ni
Removed redundant code
4deb905
@yash-ni
Fixed int64 bug
bfb4ddb
@yash-ni
Fixed labview server crash
d574c45
@yash-ni
Included all repeated datatypes in the template as well
5500fe6
@yash-ni
Using same old parsing method for strings
7647266
@yash-ni
fixed string parsing to return ptr
aaee3cb
@CPattar-NI
parse using google::protobuf::RepeatedField<char> _repeatedMessageValues
cc61d1a
@yash-ni
Added enum class for data types
566274f
@CPattar-NI
using grpc repeatedField as vectors
c14f921
@yash-ni
Removed case structure and extra comparision overhead
6304aab
@yash-ni
Made changes for all streaming cases
ab0ea6a
@yash-ni
Made changes to all rpc vim files
88903f4
@yash-ni
Removed extra enum parameter
bcb13ef
@CPattar-NI
String parse
1bed38e
@yash-ni
Merge branch 'users/cpattar/remove-temp-structures' into remove-temp-…
e8e66c4 
…structures
@yash-ni
Changed lvClusterHandle to raw pointer instead of shared pointer
425b991
@yash-ni
Reverted build spec
84b5b7b
@yash-ni
Commented datatype enum
c53d19c
@CPattar-NI
Merge pull request #1 from yash-ni/remove-temp-structures
ee2e4dd 
Added templates for all repeating and non-repeating datatypes.
@CPattar-NI
split ParseAndCopyMessage into single and repeated
1016ec0
@CPattar-NI
clearing local gitignore changes
42805cd
CPattar-NI and others added 15 commits January 10, 2024 16:38
@CPattar-NI
Adding debug symbols for release build, adding feature toggle class
7b2f5dd
@CPattar-NI
Adding files to cmake, and using the feature toggle class
ea42913
@CPattar-NI
Merge branch 'users/cpattar/create-feature-toggle-infra' into users/c…
488bf95 
…pattar/remove-temp-structures
@CPattar-NI
Merge branch 'master' into users/cpattar/create-feature-toggle-infra
3acb1a0
@CPattar-NI
Code cleanup
cc24a01
@CPattar-NI
Continue index required for nested message type only.
9c20e5d
@CPattar-NI
Config file read in InitCallback is enough
bd77565
@CPattar-NI
Merge branch 'users/cpattar/create-feature-toggle-infra' of https://g…
bdab389 
…ithub.com/CPattar-NI/grpc-labview into users/cpattar/create-feature-toggle-infra
@CPattar-NI
Merge branch 'users/cpattar/create-feature-toggle-infra' into users/c…
b20ca1f 
…pattar/remove-temp-structures
@CPattar-NI
remove empty LVCluster declaration
fe5e0f2
@CPattar-NI
Removing feature toggle header
2132292
@CPattar-NI
Adding a PostParseAction to enable custom post action. In this case, …
d93084a 
…copying into LV cluster when required.
@CPattar-NI
merge feature toggle branch commit
aab0398
@CPattar-NI
Removing efficient copy for streaming clients
2ab27d5
@CPattar-NI
Cleaning up code from streaming calls
c417c3d
@CPattar-NI CPattar-NI changed the title Client side communication performance improvements Client side unary communication performance improvements Jan 19, 2024
@pratheekshasn pratheekshasn merged commit 0020685 into ni:master Jan 24, 2024
5 checks passed
@dixonjoel dixonjoel mentioned this pull request Feb 20, 2024
Closed
@ni-sujain ni-sujain mentioned this pull request Mar 13, 2024
Merged
@jasonmreding jasonmreding mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chethanravindranath chethanravindranath chethanravindranath left review comments

@ni-sujain ni-sujain ni-sujain left review comments

@pratheekshasn pratheekshasn pratheekshasn approved these changes

@yash-ni yash-ni Awaiting requested review from yash-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CPattar-NI @pratheekshasn @ni-sujain @chethanravindranath @yash-ni