fixing crashes related to Repeated NestedMessage Parsing and bugs in PackToAny API #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for ni/measurement-plugin-labview#485, #351
Issue
Given a proto file having repeated NestedMessage
e.g.
LV client was crashing. This started happening after #335 where we added some client-side performance improvements. It turns out that while parsing repeated Nested Messages/Strings
DSNewHandle
does not work properly can lead to access violations intdcore
.Fix
_repeatedStringValuesMap
. UsedcontinueIndex
from parent NestedMessage to formulate unique key for_repeatedStringValuesMap
1UL
.