Add support for LabVIEW PPL LabVIEW UIs in built apps #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbirkhol-ni
requested review from
dixonjoel,
csjall,
aepete and
nstokes-nati
as code owners
pbirkhol-ni
commented
Aug 8, 2023
...asurements/Keysight 34401A DMM Measurement/Keysight 34401A DMM Measurement/Get UI Details.vi
Show resolved
Hide resolved
pbirkhol-ni
commented
Aug 8, 2023
Source/Runtime/MeasurementLink Measurement Server/Build Assets/Post-Build Action.vi
Show resolved
Hide resolved
dixonjoel
approved these changes
Aug 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR fixes the issue in #240 and also partially fixes the issue in #245. It is not necessarily the ideal solution, but it will get customers further than they are today.
Post-Build Action.vito support copying LabVIEW UIs that are in PPLs. Prior to this change, trying to copy a LabVIEW UI in a PPL would error, which would break your build spec. Note that the PPL must be in the same directory as theMeasurement UI.vi.Keysight 34401A DMM Measurementexample to use a PPL for its UI. This fixes the issue inKeysight 34401A DMM MeasurementUI doesn't work when statically registered #240 and also provides an example for how to use PPL-based UIs.Why should this Pull Request be merged?
Any reasonably complex UI will require external dependencies. I anticipate this to be a common workflow and we should have a solution, even if it isn't the ideal solution.
What testing has been done?
I tested using standalone Measurement UIs and PPL UIs, both with dynamic registration and static registration.