For built exes, copy the entire containing directory for PPL UIs #257
Conversation
pbirkhol-ni
requested review from
dixonjoel,
csjall,
aepete and
nstokes-nati
as code owners
...asurements/Keysight 34401A DMM Measurement/Keysight 34401A DMM Measurement/Get UI Details.vi
Show resolved
Hide resolved
Source/Runtime/MeasurementLink Measurement Server/Build Assets/Post-Build Action.vi
Show resolved
Hide resolved
Source/Runtime/MeasurementLink Measurement Server/Build Assets/Post-Build Action.vi
Show resolved
Hide resolved
|
Please update the PR title before submitting for accuracy when looking back at PRs. |
Ugh. Why is github like this? |
pbirkhol-ni
changed the title
The default behavior probably makes more sense for forks that don't have FYI, there is an action to run checks on the PR title: https://github.com/marketplace/actions/pr-title-checker |
There was a problem hiding this comment.
The exe buildspec is still pulling in Measurement UI.vi which isn't necessary. This is something that we should fix across all of our examples and the generator. If you want to address this in a follow on PR with a more comprehensive set of changes, I'm fine with that.
Sure. I'll do a quick follow-on PR. |
What does this Pull Request accomplish?
I received some offline feedback for #255. It didn't handle the case where the UI PPL had external dll dependencies. This change will copy the entire containing PPL directory during the build so that any necessary dlls also get copied. It also updates the Keysight example and documentation to mention that PPLs should be placed in a subdirectory next to the
Measurement Logic.vi.Why should this Pull Request be merged?
We don't expect UIs with dll dependencies will be common, but it is certainly possible and we should support it.
What testing has been done?
I created a measurement with a UI that uses the LabVIEW keyboard VIs, which has a dependency on
lvinput.dll. I verified that before my change, the UI wouldn't load in InstrumentStudio. After the change, the dll gets copied and the UI loads.