Use type definition name of actual DoubleXYData .ctl #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check whether a type def is DoubleXYData.
...e/Runtime/MeasurementLink Measurement Server/Helpers/Type Definition Name To Message Name.vi
Outdated
Show resolved
Hide resolved
...e/Runtime/MeasurementLink Measurement Server/Helpers/Type Definition Name To Message Name.vi
Outdated
Show resolved
Hide resolved
Source/Runtime/MeasurementLink Measurement Server/Helpers/Is Supported Cluster.vi
Outdated
Show resolved
Hide resolved
jasonmreding
approved these changes
Nov 16, 2023
pbirkhol-ni
reviewed
Nov 27, 2023
|
@jasonmreding @pbirkhol-ni I find myself reconsidering whether this is better than what we have. A couple drawbacks are that it's just more complicated logic and it also gives us a compile-time dependency on the NI gRPC Types package. I'm not totally convinced it's better than this simple case structure logic that we can expand over time. What do y'all think? |
…ent-service-depends-on-ni-protobuf-types
…' in Is Supported Cluster.vi
…ent-service-depends-on-ni-protobuf-types
dixonjoel
deleted the
users/jdixon/measurement-service-depends-on-ni-protobuf-types
branch
jasonmreding
added a commit
that referenced
this pull request
Dec 5, 2023
* main: Update examples to use new Run Service.vi (#429) Update the service class of the .measui for LabVIEW Game of Life. It was still pointing to the .NET measurement service. (#427) Add unit tests for data type checking (#426) Update Keysight doc and delete UIProgressUpdates (#425) Create a generic VISA example (#421) Remove UI Progress Updates example. Game of Life covers the same features (#424) Bump version for pre-release (#423) Fix up Get Metadata from Configuration and Results to use a common subVI. Fix the logic for getting the array element type (#422) examples: Add gRPC support to VISA example (34401A) (#416) Remove breakpoint (#420) Use type definition name of actual DoubleXYData .ctl (#410) Add a VISA plugin for generic VISA support (#413) examples: Fix lvlib references to old TestStand VI names (#415) Fix ni_protobuf_types.vipb source path and build number (#414) Add game of life example (#402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a dependency to the NI gRPC Types VI package >= 1.0.0.1 to Measurement Service.vipb.
Why should this Pull Request be merged?
Ensure customers have the NI gRPC Types package installed as needed.
What testing has been done?
Interactive testing with a LV service.