-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a VISA plugin for generic VISA support #413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbirkhol-ni
commented
Nov 17, 2023
Source/Runtime/MeasurementLink VISA/Session Factory/Session Factory.lvclass
Show resolved
Hide resolved
Source/Runtime/MeasurementLink VISA/Session Factory/Session Factory.lvclass
Show resolved
Hide resolved
jasonmreding
approved these changes
Nov 27, 2023
Source/Runtime/MeasurementLink VISA/Session Factory/Close MeasurementLink Session.vi
Show resolved
Hide resolved
jasonmreding
added a commit
that referenced
this pull request
Dec 5, 2023
* main: Update examples to use new Run Service.vi (#429) Update the service class of the .measui for LabVIEW Game of Life. It was still pointing to the .NET measurement service. (#427) Add unit tests for data type checking (#426) Update Keysight doc and delete UIProgressUpdates (#425) Create a generic VISA example (#421) Remove UI Progress Updates example. Game of Life covers the same features (#424) Bump version for pre-release (#423) Fix up Get Metadata from Configuration and Results to use a common subVI. Fix the logic for getting the array element type (#422) examples: Add gRPC support to VISA example (34401A) (#416) Remove breakpoint (#420) Use type definition name of actual DoubleXYData .ctl (#410) Add a VISA plugin for generic VISA support (#413) examples: Fix lvlib references to old TestStand VI names (#415) Fix ni_protobuf_types.vipb source path and build number (#414) Add game of life example (#402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Close MeasurementLink Session.vi
ignores theinitialize and close session behavior
input. It just unconditionally callsVISA Close
because the close behavior is defined during init.VISA Open for gRPC Session.vi
has anOpen / Close Behavior
input that has anAuto
enum value. However, the ISessionFactoryinitialize and close session behavior
enum does not have anAuto
value. What this means is that we never passAuto
toVISA Open for gRPC Session.vi
, which I think is okay but I can't 100% convince myself.What testing has been done?
Auto tests.