Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up measlinkbot to all GitHub workflows #509

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

MounikaBattu17
Copy link
Contributor

@MounikaBattu17 MounikaBattu17 commented Apr 24, 2024

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

This PR replaces spawningpool runner with measlinkbot (AWS runner) in all workflows (run g tests, run vi analyzer, run PR commenter.
Implements Technical Debt 2350468: Redundant / externally-maintained test runners.

Why should this Pull Request be merged?

  1. Replaced spawningpool with rdss-measlinkbot-win-10-lv64 in runs-on field for all workflows.
  2. run g tests: will parallelly run on four versions of LabVIEW (2020, 2021, 2022, 2023).
  3. run vi analyzer: will run on LabVIEW 2023.
  4. run PR commenter: will run on LabVIEW 2023.
  5. Hardcoded LabVIEW path and port number in run_diff.py, run_vi_analyzer.py.
  6. Skipped three Discovery Client tests as it causes LabVIEW hang at times.

Note:

  • In all workflows, LabVIEW is opened and closed properly to avoid LabVIEW CLI connection error (TCP/IP connection error).
  • As measlinkbot is on demand AWS runner, it takes 10-15 minutes for runners to warm and pick up the jobs after requested, thus all workflows time will be increased by 10-15 minutes.
  • we can run maximum of 9 measlinkbot runners parallelly, if needed more, the workflow will simply wait (pending/queued state) for working runners to complete and then will execute pending workflows.
  • If workflow fails for any abrupt reasons other than test failures, we recommend to rerun the workflow after some time.
  • Changes like updating documentation on measlinkbot, removing patch work code added for spawningpool, will be made in the upcoming PR.

What testing has been done?

The checks in the PR.

Copy link

0 of 0 files processed successfully.

@dixonjoel
Copy link
Collaborator

@MounikaBattu17 It looks like this PR is ready to go. But the 'main' branch is set up to wait for 'Run LabVIEW Tests / Run G Tests' which doesn't exist in this branch with these changes. So I'm going to go ahead and disable that check, submit this, and then make one or more of the Run G Tests LV20XX required to check in.

@dixonjoel dixonjoel merged commit 159a913 into main Apr 24, 2024
6 checks passed
@dixonjoel dixonjoel deleted the users/mounika/setup-measlinbkbot-lv64-runner branch April 24, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants