-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Working version for Small 2d and BRT] Small 2D and BRT fixes #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
philipmac
reviewed
Dec 18, 2023
philipmac
reviewed
Dec 18, 2023
philipmac
reviewed
Dec 18, 2023
philipmac
reviewed
Dec 18, 2023
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
9 times, most recently
from
December 22, 2023 13:22
cab2b16
to
90a617f
Compare
add .submit for all non-mapped tasks
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
December 22, 2023 13:30
90a617f
to
ebc49fe
Compare
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
December 22, 2023 13:31
ebc49fe
to
eaed041
Compare
philipmac
approved these changes
Dec 22, 2023
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
December 28, 2023 17:30
55b671f
to
00087e6
Compare
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
December 28, 2023 21:33
eff11d7
to
ad93a6e
Compare
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
January 3, 2024 16:49
b2443c7
to
0633041
Compare
annshress
force-pushed
the
fix/small_two_d_fix_and_log
branch
from
January 3, 2024 17:01
0633041
to
bdec9fd
Compare
Closing...
|
annshress
changed the title
Small 2D and BRT fixes
[Working version for BRT] Small 2D and BRT fixes
Jan 8, 2024
annshress
changed the title
[Working version for BRT] Small 2D and BRT fixes
[Working version for Small 2d and BRT] Small 2D and BRT fixes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
notify api running
calls as soon as the flow runs startCompletion/Failed
to originalsuccess/error
api calls on notify-api-completioncleanup workdir
moved to hooks from tasks.Shortcomings
utils.py
are:get_flow_run_tmpdirs
andstore_exception_hook
(for two respective issues).This PR doesn't introduce any:
print
statementsos.environ['user']
)This PR contains valid: