Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Working version for Small 2d and BRT] Small 2D and BRT fixes #409

Closed
wants to merge 21 commits into from
Closed

[Working version for Small 2d and BRT] Small 2D and BRT fixes #409

wants to merge 21 commits into from

Commits on Dec 18, 2023

  1. Fail if not exist in get_input_dir 

    Alter gen fps
    @philipmac @annshress
    philipmac authored and annshress committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    cce30e0 View commit details
    Browse the repository at this point in the history

  2. Add .submit() call to all non-mapped tasks

    @annshress
    annshress committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3c9ee45 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Add .submit for cleanup and callback tasks 

    add .submit for all non-mapped tasks
    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    3011430 View commit details
    Browse the repository at this point in the history

  2. Revert success/error codes to original

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    a0ef150 View commit details
    Browse the repository at this point in the history

  3. Add missing func call for if/else check in status

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    906eb4b View commit details
    Browse the repository at this point in the history

  4. wait on future.results before async, fixes #408

    @philipmac @annshress
    philipmac authored and annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    a45a4e0 View commit details
    Browse the repository at this point in the history

  5. Add .result() to wait for the Future results

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    89b5796 View commit details
    Browse the repository at this point in the history

  6. Allow BRT runs to fail

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    64924cf View commit details
    Browse the repository at this point in the history

  7. Add allow-failure annotations test

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c839ef1 View commit details
    Browse the repository at this point in the history

  8. Add allow_fail for every mapped params; Return valid filtered result

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8f80b59 View commit details
    Browse the repository at this point in the history

  9. Pass upstream tasks as param for downstream task

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7f200cb View commit details
    Browse the repository at this point in the history

  10. Use high slurm cluster for brt

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    eaed041 View commit details
    Browse the repository at this point in the history

  11. Add BRT test

    @annshress
    annshress committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    cf09ce7 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Add cleanup workdir as hook instead

    @annshress
    annshress committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8d6604e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Replace logger in hooks with file i/o

    @annshress
    annshress committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e711e99 View commit details
    Browse the repository at this point in the history

  2. Add generate-flow-run name

    @annshress
    annshress committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    60a9157 View commit details
    Browse the repository at this point in the history

  3. Update partially correct brt tests

    @annshress
    annshress committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d701d26 View commit details
    Browse the repository at this point in the history

  4. Fix hooks log writer

    @annshress
    annshress committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ad93a6e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Add store-exception hook on task failure

    @annshress
    annshress committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ede3f5d View commit details
    Browse the repository at this point in the history

  2. Add generate primary fp element for error objects

    @annshress
    annshress committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f6f46d2 View commit details
    Browse the repository at this point in the history

  3. Use store exception hook for brt flow

    @annshress
    annshress committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    bdec9fd View commit details
    Browse the repository at this point in the history