Fix #22604: Propagate info about terminating branches #22608
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22604
Propagates a new
nfEndBlock
flag for branches that terminate the block, improves type inference and unreachable code detection.I don't know what
sempass2
is for, so if that needs to handle this situation too please provide feedback.Thinks the echo for
"hey iterator"
in #20362 is unreachable even though it prints, so either that case needs to be made consistent or the propagation needs to somehow work around this behavior.Alternative to this pr would be making
endsInNoReturn
check the appropriate node types.