Fix #22604: Make endsInNoReturn traverse the tree #22612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acceptable for now but the spec doesn't imply that type checking has to care about |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
Other languages have "never" types for this |
|
Well I know nothing of language design, just (trying to) solve interesting looking problems. You’re right though, never type looks pretty good compared to this. |
That doesn't improve the situation all that much, so you introduce weirdo types that do not compose and need special handling elsewhere. What is a |
narimiran
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Rewrite endsInNoReturn * Handle `try` stmt again and add tests * Fix unreachable code warning * Remove unreachable code in semexprs again * Check `it.len` before skip * Move import of assertions --------- Co-authored-by: SirOlaf <> (cherry picked from commit 3b206ed)
narimiran
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Rewrite endsInNoReturn * Handle `try` stmt again and add tests * Fix unreachable code warning * Remove unreachable code in semexprs again * Check `it.len` before skip * Move import of assertions --------- Co-authored-by: SirOlaf <> (cherry picked from commit 3b206ed)
narimiran
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Rewrite endsInNoReturn * Handle `try` stmt again and add tests * Fix unreachable code warning * Remove unreachable code in semexprs again * Check `it.len` before skip * Move import of assertions --------- Co-authored-by: SirOlaf <> (cherry picked from commit 3b206ed)
narimiran
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Rewrite endsInNoReturn * Handle `try` stmt again and add tests * Fix unreachable code warning * Remove unreachable code in semexprs again * Check `it.len` before skip * Move import of assertions --------- Co-authored-by: SirOlaf <> (cherry picked from commit 3b206ed)
narimiran
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Rewrite endsInNoReturn * Handle `try` stmt again and add tests * Fix unreachable code warning * Remove unreachable code in semexprs again * Check `it.len` before skip * Move import of assertions --------- Co-authored-by: SirOlaf <> (cherry picked from commit 3b206ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22604
endsInNoReturnnow traverses relevant nodes to determine if the block really doesn't return.Same story as in previous pr, improves type inference and unreachable code detection somewhat, iterator example also now not seen as a noreturn, so thanks for stopping the flag nonsense I was doing.
Alternative to #22608