Fixes an issue where two types can collide in the cgen #23937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a header with
--header
and then using it from another Nim project to import the generated types, generic instances can collide and produce an error.i.e.
typedef MyGeneric[TypeA] typename
typedef MyGeneric[TypeB] typename
signature
here cant be the same as they are different types.This issue can be avoided by using the Nim type as part of the name which is what this PR does.
Update:
Encode types so
MyClass[T]
becomestypedef MyClass<NI> TY_MyClass_int;
instead ofTy_QjHlYnbKApuWy39cRg7R7dw
Update 2: