Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where two types can collide in the cgen #23937

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from

Commits on Aug 14, 2024

  1. Fixes an issue where two types can collide in the cgen

    When generating a header with `--header` and then using it from another Nim project to import the generated types, generic instances can collide and produce an error i.e. `typedef MyGeneric[TypeA] typename` `typedef MyGeneric[TypeB] typename` `signature` here cant be the same as they are different types.  This issue can be avoided by using the Nim type as part of the name which is what PR does.
    jmgomez committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    61392ae View commit details
    Browse the repository at this point in the history
  2. Better encoding

    Encode types so   `MyClass[T]` becomes `typedef MyClass<NI>  TY_MyClass_int;` instead of `Ty_QjHlYnbKApuWy39cRg7R7dw`
    jmgomez committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    13f13f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5cb3ac View commit details
    Browse the repository at this point in the history
  4. improves collision handling

    jmgomez committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1bb8e0c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. remove cache

    jmgomez committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fdabed2 View commit details
    Browse the repository at this point in the history
  2. constraints affected types

    jmgomez committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2e2e4dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40db3c7 View commit details
    Browse the repository at this point in the history