Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure 2mm template is added when running CIFTI #381

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Aug 23, 2024

Closes #380

@madisoth I believe this should do the trick - running a local test now.

@scott-huberty
Copy link
Contributor

@mgxd How tough do you think it would it be to add a regression test for this? Been thinking about #378 and ways that we can make the testing more comprehensive. Open to your thoughts!

@mgxd
Copy link
Collaborator Author

mgxd commented Aug 26, 2024

@scott-huberty re this behavior - the configuration test should have caught this (and I think originally did), but I altered it during the fit-apply refactor due to poor documentation...now the test is back in place.

@mgxd mgxd merged commit a01b1c8 into nipreps:master Aug 26, 2024
9 checks passed
@mgxd mgxd deleted the fix/cifti-resample branch August 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bold_MNIInfant_wf uses res-1 (1mm) template as target for BOLD resampling
2 participants